Production hardening: security fixes, code quality, 724 skills complete

- Fix 25 shell=True subprocess calls with list-based commands
- Fix 49 verify=False in defensive skills (env-var override)
- Add timeout to 231 HTTP/subprocess/socket calls
- Fix 6 SQL injection patterns with whitelist validation
- Replace 8 __import__() with standard imports
- Remove 701 unused imports across 442 files
- Add authorized-testing disclaimers to all offensive skills
- Complete 11 incomplete skill directories
- Expand 10 stub SKILL.md files with full content
- Fix 2 YAML parse errors in frontmatter
- Fix 5 pre-existing syntax errors
- Convert 22 hardcoded paths/ports to environment variables
- Back up 21 redundant skill pairs to .bak
- Fix 2 global declaration errors
- 724/724 skills with full folder anatomy (SKILL.md + agent.py + api-reference.md + LICENSE)
- 0 compile errors across all 724 agent.py files

skills/analyzing-linux-elf-malware/scripts/agent.py

@@ -6,12 +6,10 @@ import math
 import os
 import sys
 import subprocess
-import struct
 from collections import Counter
 
 try:
     from elftools.elf.elffile import ELFFile
-    from elftools.elf.sections import SymbolTableSection
     HAS_ELFTOOLS = True
 except ImportError:
     HAS_ELFTOOLS = False
@@ -85,9 +83,9 @@ def analyze_sections(filepath):
 def extract_strings(filepath, min_length=6):
     """Extract ASCII strings from the binary and categorize by type."""
     stdout, _, rc = subprocess.run(
-        f"strings -n {min_length} {filepath}", shell=True,
+        ["strings", "-n", str(min_length), filepath],
         capture_output=True, text=True
-    ).stdout, "", 0
+, timeout=120).stdout, "", 0
     if not stdout:
         return {}
     all_strings = stdout.strip().splitlines()
@@ -126,8 +124,9 @@ def check_packing(filepath):
         indicators.append("UPX packer detected (UPX! magic)")
     if b"UPX0" in data or b"UPX1" in data:
         indicators.append("UPX section names found")
-    stdout, _, _ = subprocess.run(f"upx -t {filepath} 2>&1", shell=True,
-                                   capture_output=True, text=True).stdout, "", 0
+    stdout, _, _ = subprocess.run(["upx", "-t", filepath],
+                                   capture_output=True, text=True,
+                                   stderr=subprocess.STDOUT, timeout=120).stdout, "", 0
     if stdout and "packed" in stdout.lower():
         indicators.append("UPX verification confirms packing")
     return indicators
@@ -135,8 +134,8 @@ def check_packing(filepath):
 
 def analyze_dynamic_linking(filepath):
     """Analyze dynamic linking information and imported functions."""
-    stdout, _, rc = subprocess.run(f"readelf -d {filepath}", shell=True,
-                                    capture_output=True, text=True).stdout, "", 0
+    stdout, _, rc = subprocess.run(["readelf", "-d", filepath],
+                                    capture_output=True, text=True, timeout=120).stdout, "", 0
     dynamic_info = {"libraries": [], "rpath": None}
     if stdout:
         for line in stdout.splitlines():
@@ -146,10 +145,17 @@ def analyze_dynamic_linking(filepath):
             if "RPATH" in line or "RUNPATH" in line:
                 dynamic_info["rpath"] = line.split("[")[-1].rstrip("]")
 
-    stdout2, _, _ = subprocess.run(
-        f"readelf -r {filepath} | grep -E 'socket|connect|exec|fork|open|write|bind|listen|send|recv'",
-        shell=True, capture_output=True, text=True
-    ).stdout, "", 0
+    readelf_proc = subprocess.run(
+        ["readelf", "-r", filepath],
+        capture_output=True, text=True,
+        timeout=120,
+    )
+    import re as _re
+    suspicious_funcs = _re.compile(r'socket|connect|exec|fork|open|write|bind|listen|send|recv')
+    stdout2 = "\n".join(
+        line for line in (readelf_proc.stdout or "").splitlines()
+        if suspicious_funcs.search(line)
+    )
     dynamic_info["suspicious_imports"] = [
         line.strip() for line in (stdout2 or "").splitlines() if line.strip()
     ]