Production hardening: security fixes, code quality, 724 skills complete

- Fix 25 shell=True subprocess calls with list-based commands
- Fix 49 verify=False in defensive skills (env-var override)
- Add timeout to 231 HTTP/subprocess/socket calls
- Fix 6 SQL injection patterns with whitelist validation
- Replace 8 __import__() with standard imports
- Remove 701 unused imports across 442 files
- Add authorized-testing disclaimers to all offensive skills
- Complete 11 incomplete skill directories
- Expand 10 stub SKILL.md files with full content
- Fix 2 YAML parse errors in frontmatter
- Fix 5 pre-existing syntax errors
- Convert 22 hardcoded paths/ports to environment variables
- Back up 21 redundant skill pairs to .bak
- Fix 2 global declaration errors
- 724/724 skills with full folder anatomy (SKILL.md + agent.py + api-reference.md + LICENSE)
- 0 compile errors across all 724 agent.py files
This commit is contained in:
mukul975
2026-03-19 13:26:49 +01:00
parent 63b442d347
commit c47eed6a64
900 changed files with 23085 additions and 2720 deletions
@@ -3,6 +3,7 @@
import json
import logging
import os
import argparse
from datetime import datetime
@@ -22,25 +23,25 @@ class PfSenseAPI:
"Authorization": f"{api_key} {api_secret}",
"Content-Type": "application/json",
})
self.session.verify = False
self.session.verify = not os.environ.get("SKIP_TLS_VERIFY", "").lower() == "true" # Set SKIP_TLS_VERIFY=true for self-signed certs in lab environments
def get(self, endpoint):
resp = self.session.get(f"{self.base_url}/api/v1/{endpoint}")
resp = self.session.get(f"{self.base_url}/api/v1/{endpoint}", timeout=30)
resp.raise_for_status()
return resp.json()
def post(self, endpoint, data):
resp = self.session.post(f"{self.base_url}/api/v1/{endpoint}", json=data)
resp = self.session.post(f"{self.base_url}/api/v1/{endpoint}", json=data, timeout=30)
resp.raise_for_status()
return resp.json()
def put(self, endpoint, data):
resp = self.session.put(f"{self.base_url}/api/v1/{endpoint}", json=data)
resp = self.session.put(f"{self.base_url}/api/v1/{endpoint}", json=data, timeout=30)
resp.raise_for_status()
return resp.json()
def delete(self, endpoint, data=None):
resp = self.session.delete(f"{self.base_url}/api/v1/{endpoint}", json=data)
resp = self.session.delete(f"{self.base_url}/api/v1/{endpoint}", json=data, timeout=30)
resp.raise_for_status()
return resp.json()