Production hardening: security fixes, code quality, 724 skills complete

- Fix 25 shell=True subprocess calls with list-based commands
- Fix 49 verify=False in defensive skills (env-var override)
- Add timeout to 231 HTTP/subprocess/socket calls
- Fix 6 SQL injection patterns with whitelist validation
- Replace 8 __import__() with standard imports
- Remove 701 unused imports across 442 files
- Add authorized-testing disclaimers to all offensive skills
- Complete 11 incomplete skill directories
- Expand 10 stub SKILL.md files with full content
- Fix 2 YAML parse errors in frontmatter
- Fix 5 pre-existing syntax errors
- Convert 22 hardcoded paths/ports to environment variables
- Back up 21 redundant skill pairs to .bak
- Fix 2 global declaration errors
- 724/724 skills with full folder anatomy (SKILL.md + agent.py + api-reference.md + LICENSE)
- 0 compile errors across all 724 agent.py files
This commit is contained in:
mukul975
2026-03-19 13:26:49 +01:00
parent 63b442d347
commit c47eed6a64
900 changed files with 23085 additions and 2720 deletions
@@ -2,6 +2,7 @@
"""Historian server attack detection agent for ICS/SCADA environments."""
import json
import os
import sys
import argparse
import socket
@@ -51,7 +52,8 @@ def check_pi_web_api(host, username=None, password=None):
results = {"host": host, "checks": []}
try:
resp = requests.get(f"{base}/system", auth=auth, verify=False, timeout=10)
resp = requests.get(f"{base}/system", auth=auth,
verify=not os.environ.get("SKIP_TLS_VERIFY", "").lower() == "true", timeout=10) # Set SKIP_TLS_VERIFY=true for self-signed certs in lab environments
if resp.status_code == 200:
data = resp.json()
results["product_version"] = data.get("ProductTitle", "")
@@ -67,7 +69,8 @@ def check_pi_web_api(host, username=None, password=None):
results["error"] = str(e)
try:
resp = requests.get(f"{base}/points", auth=auth, verify=False,
resp = requests.get(f"{base}/points", auth=auth,
verify=not os.environ.get("SKIP_TLS_VERIFY", "").lower() == "true",
params={"maxCount": 10}, timeout=10)
if resp.status_code == 200:
points = resp.json().get("Items", [])