Production hardening: security fixes, code quality, 724 skills complete

- Fix 25 shell=True subprocess calls with list-based commands
- Fix 49 verify=False in defensive skills (env-var override)
- Add timeout to 231 HTTP/subprocess/socket calls
- Fix 6 SQL injection patterns with whitelist validation
- Replace 8 __import__() with standard imports
- Remove 701 unused imports across 442 files
- Add authorized-testing disclaimers to all offensive skills
- Complete 11 incomplete skill directories
- Expand 10 stub SKILL.md files with full content
- Fix 2 YAML parse errors in frontmatter
- Fix 5 pre-existing syntax errors
- Convert 22 hardcoded paths/ports to environment variables
- Back up 21 redundant skill pairs to .bak
- Fix 2 global declaration errors
- 724/724 skills with full folder anatomy (SKILL.md + agent.py + api-reference.md + LICENSE)
- 0 compile errors across all 724 agent.py files
This commit is contained in:
mukul975
2026-03-19 13:26:49 +01:00
parent 63b442d347
commit c47eed6a64
900 changed files with 23085 additions and 2720 deletions
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
1. Definitions.
"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.
"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.
"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.
"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.
"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.
"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.
"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).
"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.
"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to the Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."
"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by the Licensor and
subsequently incorporated within the Work.
2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.
3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.
4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:
(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and
(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and
(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding any notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.
You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.
5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.
6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.
7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.
8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.
9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.
END OF TERMS AND CONDITIONS
APPENDIX: How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. Please do not remove or change
the license header comment from a contributed file except when
necessary.
Copyright 2026 mukul975
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
@@ -0,0 +1,41 @@
---
name: implementing-email-security-with-dmarc-dkim-spf
description: >-
Audit and validate email authentication configurations by checking SPF, DKIM,
and DMARC DNS records for a domain. Uses dnspython to query TXT records,
validates SPF syntax and lookup counts, verifies DKIM selector records,
parses DMARC policies, and identifies misconfigurations that enable email
spoofing. Generates remediation recommendations.
domain: cybersecurity
subdomain: security-operations
tags: [implementing, email, security, with]
version: "1.0"
author: mahipal
license: Apache-2.0
---
## Instructions
1. Install dependencies: `pip install dnspython checkdmarc`
2. Provide target domain(s) to audit.
3. Run the agent to check email security:
- Query and validate SPF records (syntax, mechanism count, includes, redirect)
- Check DKIM records for common selectors (google, default, selector1, selector2)
- Parse DMARC records (policy, subdomain policy, reporting URIs, alignment)
- Identify misconfigurations enabling spoofing
- Generate remediation recommendations
```bash
python scripts/agent.py --domain example.com --output email_security_report.json
```
## Examples
### Email Security Audit Result
```
Domain: example.com
SPF: v=spf1 include:_spf.google.com ~all (WARN: softfail allows spoofing)
DKIM: selector1 OK, selector2 OK
DMARC: v=DMARC1; p=none; rua=mailto:dmarc@example.com (WARN: policy=none, no enforcement)
Risk: HIGH - p=none with ~all allows email spoofing
```
@@ -0,0 +1,75 @@
# API Reference: Email Security (SPF/DKIM/DMARC)
## dnspython TXT Query
```python
import dns.resolver
answers = dns.resolver.resolve("example.com", "TXT")
for rdata in answers:
txt = b"".join(rdata.strings).decode("utf-8")
```
## SPF Record Format
```
v=spf1 [mechanisms] [qualifier]all
```
| Mechanism | Example | Description |
|-----------|---------|-------------|
| `include:` | `include:_spf.google.com` | Include other SPF record |
| `ip4:` | `ip4:203.0.113.0/24` | Allow IPv4 range |
| `ip6:` | `ip6:2001:db8::/32` | Allow IPv6 range |
| `a:` | `a:mail.example.com` | Allow A record IP |
| `mx:` | `mx:example.com` | Allow MX record IPs |
| `redirect=` | `redirect=_spf.example.com` | Redirect to another SPF |
| Qualifier | Meaning | Effect |
|-----------|---------|--------|
| `-all` | Fail | Reject unauthorized senders |
| `~all` | Softfail | Accept but mark |
| `?all` | Neutral | No policy |
| `+all` | Pass | Allow all (insecure) |
**Limit**: Max 10 DNS lookups (includes, a, mx, ptr, exists, redirect).
## DKIM Record Query
```
{selector}._domainkey.{domain} TXT
```
```
v=DKIM1; k=rsa; p=MIGfMA0GCSqGSIb3DQEB...
```
| Tag | Description |
|-----|-------------|
| `v` | Version (DKIM1) |
| `k` | Key type (rsa, ed25519) |
| `p` | Public key (Base64) |
| `t` | Flags (y=testing, s=strict) |
Common selectors: `google`, `default`, `selector1`, `selector2`, `k1`, `mail`, `dkim`, `s1`, `s2`, `mandrill`, `smtpapi`
## DMARC Record Query
```
_dmarc.{domain} TXT
```
```
v=DMARC1; p=reject; rua=mailto:dmarc@example.com; pct=100
```
| Tag | Values | Description |
|-----|--------|-------------|
| `p` | none/quarantine/reject | Policy for domain |
| `sp` | none/quarantine/reject | Subdomain policy |
| `pct` | 0-100 | Percentage of messages to apply policy |
| `rua` | mailto:URI | Aggregate report destination |
| `ruf` | mailto:URI | Forensic report destination |
| `adkim` | r/s | DKIM alignment (relaxed/strict) |
| `aspf` | r/s | SPF alignment (relaxed/strict) |
## Risk Scoring
| Condition | Score |
|-----------|-------|
| No SPF record | +40 critical |
| SPF +all | +40 critical |
| SPF ~all | +10 medium |
| No DKIM | +25 high |
| No DMARC | +40 critical |
| DMARC p=none | +25 high |
| DMARC pct < 100 | +10 medium |
@@ -0,0 +1,264 @@
#!/usr/bin/env python3
"""Email Security Audit Agent - Validates SPF, DKIM, and DMARC DNS records for domains."""
import json
import re
import logging
import argparse
from datetime import datetime
import dns.resolver
logging.basicConfig(level=logging.INFO, format="%(asctime)s [%(levelname)s] %(message)s")
logger = logging.getLogger(__name__)
DKIM_SELECTORS = [
"default", "google", "selector1", "selector2", "k1", "k2",
"mail", "dkim", "s1", "s2", "mandrill", "everlytickey1",
"smtpapi", "pic", "protonmail", "protonmail2", "protonmail3",
]
def query_txt_records(domain, prefix=""):
"""Query TXT DNS records for a domain."""
fqdn = f"{prefix}.{domain}" if prefix else domain
try:
answers = dns.resolver.resolve(fqdn, "TXT")
records = []
for rdata in answers:
txt = b"".join(rdata.strings).decode("utf-8", errors="ignore")
records.append(txt)
return records
except (dns.resolver.NXDOMAIN, dns.resolver.NoAnswer, dns.resolver.NoNameservers, dns.exception.Timeout):
return []
def check_spf(domain):
"""Check and validate SPF record."""
records = query_txt_records(domain)
spf_records = [r for r in records if r.startswith("v=spf1")]
if not spf_records:
return {"status": "missing", "severity": "critical", "issues": ["No SPF record found"], "record": None}
if len(spf_records) > 1:
issues = ["Multiple SPF records found (RFC violation, causes permerror)"]
else:
issues = []
spf = spf_records[0]
mechanisms = spf.split()
include_count = sum(1 for m in mechanisms if m.startswith("include:"))
has_all = any(m in ("~all", "-all", "+all", "?all") for m in mechanisms)
if "+all" in mechanisms:
issues.append("SPF uses +all (allows any sender - completely open)")
severity = "critical"
elif "?all" in mechanisms:
issues.append("SPF uses ?all (neutral - no protection)")
severity = "high"
elif "~all" in mechanisms:
issues.append("SPF uses ~all (softfail - mail accepted but marked)")
severity = "medium"
elif "-all" in mechanisms:
severity = "low"
elif not has_all:
issues.append("SPF record missing -all qualifier")
severity = "high"
else:
severity = "low"
if include_count > 10:
issues.append(f"SPF has {include_count} includes (>10 DNS lookups causes permerror)")
severity = "high"
lookup_mechanisms = sum(1 for m in mechanisms if any(m.startswith(p) for p in ("include:", "a:", "mx:", "ptr:", "exists:", "redirect=")))
if lookup_mechanisms > 10:
issues.append(f"SPF exceeds 10 DNS lookup limit ({lookup_mechanisms} lookups)")
return {
"status": "found",
"record": spf,
"mechanism_count": len(mechanisms),
"include_count": include_count,
"dns_lookups": lookup_mechanisms,
"qualifier": next((m for m in mechanisms if m.endswith("all")), "none"),
"severity": severity,
"issues": issues,
}
def check_dkim(domain, selectors=None):
"""Check DKIM records for common selectors."""
if selectors is None:
selectors = DKIM_SELECTORS
found_selectors = []
for selector in selectors:
records = query_txt_records(domain, prefix=f"{selector}._domainkey")
dkim_records = [r for r in records if "v=DKIM1" in r or "k=rsa" in r or "p=" in r]
if dkim_records:
record = dkim_records[0]
key_match = re.search(r"p=([A-Za-z0-9+/=]+)", record)
key_length = len(key_match.group(1)) * 6 // 8 if key_match else 0
issues = []
if key_length and key_length < 128:
issues.append(f"DKIM key too short ({key_length} bytes, minimum 1024 bits recommended)")
if "p=" in record and not key_match:
issues.append("DKIM public key appears empty (revoked)")
found_selectors.append({
"selector": selector,
"record": record[:200],
"key_size_bytes": key_length,
"issues": issues,
})
if not found_selectors:
return {
"status": "not_found",
"severity": "high",
"issues": ["No DKIM records found for any common selector"],
"selectors_checked": len(selectors),
"selectors_found": [],
}
return {
"status": "found",
"severity": "low",
"selectors_checked": len(selectors),
"selectors_found": found_selectors,
"issues": [i for s in found_selectors for i in s["issues"]],
}
def check_dmarc(domain):
"""Check and validate DMARC record."""
records = query_txt_records(domain, prefix="_dmarc")
dmarc_records = [r for r in records if r.startswith("v=DMARC1")]
if not dmarc_records:
return {"status": "missing", "severity": "critical", "issues": ["No DMARC record found"], "record": None}
dmarc = dmarc_records[0]
tags = {}
for part in dmarc.split(";"):
part = part.strip()
if "=" in part:
key, val = part.split("=", 1)
tags[key.strip()] = val.strip()
issues = []
policy = tags.get("p", "none")
subdomain_policy = tags.get("sp", policy)
pct = int(tags.get("pct", "100"))
rua = tags.get("rua", "")
ruf = tags.get("ruf", "")
adkim = tags.get("adkim", "r")
aspf = tags.get("aspf", "r")
if policy == "none":
issues.append("DMARC policy is 'none' - no enforcement (monitoring only)")
severity = "high"
elif policy == "quarantine":
severity = "medium" if pct < 100 else "low"
if pct < 100:
issues.append(f"DMARC only applied to {pct}% of messages")
elif policy == "reject":
severity = "low"
if pct < 100:
issues.append(f"DMARC reject only applied to {pct}% of messages")
severity = "medium"
else:
severity = "high"
issues.append(f"Unknown DMARC policy: {policy}")
if not rua:
issues.append("No aggregate report URI (rua) configured")
if not ruf:
issues.append("No forensic report URI (ruf) configured")
if adkim == "r":
issues.append("DKIM alignment is relaxed (adkim=r)")
if aspf == "r":
issues.append("SPF alignment is relaxed (aspf=r)")
return {
"status": "found",
"record": dmarc,
"policy": policy,
"subdomain_policy": subdomain_policy,
"percentage": pct,
"aggregate_report": rua,
"forensic_report": ruf,
"dkim_alignment": adkim,
"spf_alignment": aspf,
"severity": severity,
"issues": issues,
}
def compute_risk_score(spf, dkim, dmarc):
"""Compute overall email security risk score."""
severity_scores = {"critical": 40, "high": 25, "medium": 10, "low": 0}
score = 0
score += severity_scores.get(spf["severity"], 0)
score += severity_scores.get(dkim["severity"], 0)
score += severity_scores.get(dmarc["severity"], 0)
if spf["status"] == "missing":
score += 20
if dmarc.get("policy") == "none":
score += 15
if score >= 60:
risk = "CRITICAL"
elif score >= 35:
risk = "HIGH"
elif score >= 15:
risk = "MEDIUM"
else:
risk = "LOW"
return {"score": score, "risk_level": risk}
def generate_report(domain, spf, dkim, dmarc, risk):
"""Generate email security audit report."""
all_issues = spf.get("issues", []) + dkim.get("issues", []) + dmarc.get("issues", [])
report = {
"timestamp": datetime.utcnow().isoformat(),
"domain": domain,
"risk_assessment": risk,
"spf": spf,
"dkim": dkim,
"dmarc": dmarc,
"total_issues": len(all_issues),
"all_issues": all_issues,
}
print(f"EMAIL SECURITY [{domain}]: Risk={risk['risk_level']} Score={risk['score']} Issues={len(all_issues)}")
return report
def main():
parser = argparse.ArgumentParser(description="Email Security Audit Agent (SPF/DKIM/DMARC)")
parser.add_argument("--domain", required=True, help="Domain to audit")
parser.add_argument("--dkim-selectors", nargs="*", help="Custom DKIM selectors to check")
parser.add_argument("--output", default="email_security_report.json")
args = parser.parse_args()
spf = check_spf(args.domain)
logger.info("SPF: %s (severity: %s)", spf["status"], spf["severity"])
dkim = check_dkim(args.domain, args.dkim_selectors)
logger.info("DKIM: %s (%d selectors found)", dkim["status"], len(dkim.get("selectors_found", [])))
dmarc = check_dmarc(args.domain)
logger.info("DMARC: %s (severity: %s)", dmarc["status"], dmarc["severity"])
risk = compute_risk_score(spf, dkim, dmarc)
report = generate_report(args.domain, spf, dkim, dmarc, risk)
with open(args.output, "w") as f:
json.dump(report, f, indent=2)
logger.info("Report saved to %s", args.output)
if __name__ == "__main__":
main()