Production hardening: security fixes, code quality, 724 skills complete

- Fix 25 shell=True subprocess calls with list-based commands
- Fix 49 verify=False in defensive skills (env-var override)
- Add timeout to 231 HTTP/subprocess/socket calls
- Fix 6 SQL injection patterns with whitelist validation
- Replace 8 __import__() with standard imports
- Remove 701 unused imports across 442 files
- Add authorized-testing disclaimers to all offensive skills
- Complete 11 incomplete skill directories
- Expand 10 stub SKILL.md files with full content
- Fix 2 YAML parse errors in frontmatter
- Fix 5 pre-existing syntax errors
- Convert 22 hardcoded paths/ports to environment variables
- Back up 21 redundant skill pairs to .bak
- Fix 2 global declaration errors
- 724/724 skills with full folder anatomy (SKILL.md + agent.py + api-reference.md + LICENSE)
- 0 compile errors across all 724 agent.py files
This commit is contained in:
mukul975
2026-03-19 13:26:49 +01:00
parent 63b442d347
commit c47eed6a64
900 changed files with 23085 additions and 2720 deletions
@@ -6,7 +6,6 @@ import argparse
import logging
import subprocess
import os
import re
from collections import defaultdict
from datetime import datetime
@@ -80,7 +79,7 @@ def deploy_opencanary(config, config_path="/etc/opencanaryd/opencanary.conf"):
json.dump(config, f, indent=2)
logger.info("Configuration written to %s", config_path)
start_cmd = ["opencanaryd", "--start"]
result = subprocess.run(start_cmd, capture_output=True, text=True)
result = subprocess.run(start_cmd, capture_output=True, text=True, timeout=120)
return {"config_path": config_path, "started": result.returncode == 0, "output": result.stdout[:200]}
@@ -159,7 +158,7 @@ def analyze_interactions(events):
def check_honeypot_status():
"""Check if OpenCanary daemon is running."""
cmd = ["opencanaryd", "--status"]
result = subprocess.run(cmd, capture_output=True, text=True)
result = subprocess.run(cmd, capture_output=True, text=True, timeout=120)
is_running = "running" in result.stdout.lower() or result.returncode == 0
return {"running": is_running, "status_output": result.stdout.strip()[:200]}