Production hardening: security fixes, code quality, 724 skills complete

- Fix 25 shell=True subprocess calls with list-based commands
- Fix 49 verify=False in defensive skills (env-var override)
- Add timeout to 231 HTTP/subprocess/socket calls
- Fix 6 SQL injection patterns with whitelist validation
- Replace 8 __import__() with standard imports
- Remove 701 unused imports across 442 files
- Add authorized-testing disclaimers to all offensive skills
- Complete 11 incomplete skill directories
- Expand 10 stub SKILL.md files with full content
- Fix 2 YAML parse errors in frontmatter
- Fix 5 pre-existing syntax errors
- Convert 22 hardcoded paths/ports to environment variables
- Back up 21 redundant skill pairs to .bak
- Fix 2 global declaration errors
- 724/724 skills with full folder anatomy (SKILL.md + agent.py + api-reference.md + LICENSE)
- 0 compile errors across all 724 agent.py files
This commit is contained in:
mukul975
2026-03-19 13:26:49 +01:00
parent 63b442d347
commit c47eed6a64
900 changed files with 23085 additions and 2720 deletions
@@ -6,7 +6,6 @@ import argparse
import logging
import subprocess
import os
from collections import defaultdict
from datetime import datetime
logging.basicConfig(level=logging.INFO, format="%(asctime)s [%(levelname)s] %(message)s")
@@ -24,7 +23,7 @@ def query_db_users(db_type, host, admin_user, admin_password):
else:
cmd = ["sqlcmd", "-S", host, "-U", admin_user, "-P", admin_password, "-Q",
"SELECT name, type_desc, is_disabled FROM sys.server_principals WHERE type IN ('S','U');"]
result = subprocess.run(cmd, capture_output=True, text=True, env=env)
result = subprocess.run(cmd, capture_output=True, text=True, env=env, timeout=120)
return [{"raw": line.strip()} for line in result.stdout.strip().split("\n") if line.strip()]
@@ -44,7 +43,7 @@ def audit_session_logging(db_type, host, admin_user, admin_password):
env = {**os.environ, "PGPASSWORD": admin_password}
if db_type == "postgresql":
cmd = ["psql", "-h", host, "-U", admin_user, "-c", "SHOW log_connections;", "--no-align", "-t"]
result = subprocess.run(cmd, capture_output=True, text=True, env=env)
result = subprocess.run(cmd, capture_output=True, text=True, env=env, timeout=120)
if "off" in result.stdout.lower():
findings.append({"issue": "log_connections disabled", "severity": "high"})
return findings