Production hardening: security fixes, code quality, 724 skills complete

- Fix 25 shell=True subprocess calls with list-based commands
- Fix 49 verify=False in defensive skills (env-var override)
- Add timeout to 231 HTTP/subprocess/socket calls
- Fix 6 SQL injection patterns with whitelist validation
- Replace 8 __import__() with standard imports
- Remove 701 unused imports across 442 files
- Add authorized-testing disclaimers to all offensive skills
- Complete 11 incomplete skill directories
- Expand 10 stub SKILL.md files with full content
- Fix 2 YAML parse errors in frontmatter
- Fix 5 pre-existing syntax errors
- Convert 22 hardcoded paths/ports to environment variables
- Back up 21 redundant skill pairs to .bak
- Fix 2 global declaration errors
- 724/724 skills with full folder anatomy (SKILL.md + agent.py + api-reference.md + LICENSE)
- 0 compile errors across all 724 agent.py files
This commit is contained in:
mukul975
2026-03-19 13:26:49 +01:00
parent 63b442d347
commit c47eed6a64
900 changed files with 23085 additions and 2720 deletions
@@ -31,7 +31,8 @@ class FirmwareAnalysisAgent:
"""Scan firmware with binwalk to identify embedded components."""
result = subprocess.run(
["binwalk", str(self.firmware_path)],
capture_output=True, text=True
capture_output=True, text=True,
timeout=120,
)
return {"output": result.stdout, "returncode": result.returncode}
@@ -40,7 +41,8 @@ class FirmwareAnalysisAgent:
extract_dir = self.output_dir / "extracted"
result = subprocess.run(
["binwalk", "-eM", "-C", str(extract_dir), str(self.firmware_path)],
capture_output=True, text=True
capture_output=True, text=True,
timeout=120,
)
return {"extract_dir": str(extract_dir), "returncode": result.returncode}
@@ -48,7 +50,8 @@ class FirmwareAnalysisAgent:
"""Run binwalk entropy analysis to detect encrypted/compressed regions."""
result = subprocess.run(
["binwalk", "-E", str(self.firmware_path)],
capture_output=True, text=True
capture_output=True, text=True,
timeout=120,
)
return {"output": result.stdout}
@@ -142,7 +145,8 @@ class FirmwareAnalysisAgent:
try:
result = subprocess.run(
["file", "--brief", str(filepath)],
capture_output=True, text=True
capture_output=True, text=True,
timeout=120,
)
if "ELF" in result.stdout:
binaries.append({