creator/agency-agents
1
0
Fork 0
mirror of https://github.com/msitarzewski/agency-agents.git synced 2026-09-03 16:50:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(install): reject unknown agent selections (#779)

Browse Source 
Signed-off-by: Mr-Neutr0n <harikp2002@gmail.com>
This commit is contained in:
hari
2026-08-26 08:46:45 -05:00
committed by GitHub
parent d536331b5a
commit 3570801f74
2 changed files with 72 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/test-agent-selection.sh
Executable
+44
View File
@@ -0,0 +1,44 @@
#!/usr/bin/env bash
# Regression coverage for install.sh agent-selection validation.
set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
INSTALLER="$SCRIPT_DIR/install.sh"
AGENTS_FILE="$(mktemp "${TMPDIR:-/tmp}/agency-agent-selection.XXXXXX")"
trap 'rm -f "$AGENTS_FILE"' EXIT
set +e
output="$($INSTALLER --tool claude-code --agent definitely-not-an-agent --dry-run 2>&1)"
status=$?
set -e
[[ "$status" -ne 0 ]] || {
printf 'Unknown --agent selection unexpectedly succeeded:\n%s\n' "$output" >&2
exit 1
}
[[ "$output" == *"Unknown agent"* ]] || {
printf 'Unknown --agent selection did not explain the error:\n%s\n' "$output" >&2
exit 1
}
printf '%s\n' 'definitely-not-an-agent' > "$AGENTS_FILE"
set +e
output="$($INSTALLER --tool claude-code --agents-file "$AGENTS_FILE" --dry-run 2>&1)"
status=$?
set -e
[[ "$status" -ne 0 ]] || {
printf 'Unknown agents-file entry unexpectedly succeeded:\n%s\n' "$output" >&2
exit 1
}
[[ "$output" == *"in agents-file"* ]] || {
printf 'Unknown agents-file entry did not identify its source:\n%s\n' "$output" >&2
exit 1
}
output="$($INSTALLER --tool claude-code --agent 'Developer Tooling Engineer' --dry-run 2>&1)"
[[ "$output" == *"Agents: 1"* ]] || {
printf 'Valid display-name selection did not resolve to one agent:\n%s\n' "$output" >&2
exit 1
}
echo "PASS: install.sh rejects unknown agent selections and accepts display names"