From 93f3c5f81837cb784e225c3cebe5c3620d7d3cd4 Mon Sep 17 00:00:00 2001
From: Michael Sitarzewski <msitarzewski@users.noreply.github.com>
Date: Wed, 17 Jun 2026 22:48:03 -0500
Subject: [PATCH] check-divisions: enumerate git-tracked dirs, not a filesystem
 glob (#597)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

actual_dirs() globbed the filesystem (`for d in */`), so it picked up gitignored
or otherwise untracked top-level directories — e.g. a local notes/ scratch dir —
and reported them as "division(s) not in divisions.json". That's a false
failure: CI uses a clean `actions/checkout` and never sees those dirs, so the
check passed in CI but failed locally, undermining a guard meant to be run
locally before pushing.

Use `git ls-files` to enumerate only top-level dirs that contain a tracked file,
keeping the dot-prefix and NON_DIVISION_DIRS filters. Local now matches CI.

Verified: passes at 16 divisions; an untracked dir is ignored; a tracked
unregistered division dir still fails the check.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 scripts/check-divisions.sh | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/scripts/check-divisions.sh b/scripts/check-divisions.sh
index 0e8ec253..6cb8f920 100755
--- a/scripts/check-divisions.sh
+++ b/scripts/check-divisions.sh
@@ -45,16 +45,18 @@ canonical() {
     | sed -E 's/"([a-z0-9-]+)".*/\1/' | sort -u
 }
 
-# Actual division directories on disk (top-level dirs minus the excludes and
-# anything dot-prefixed).
+# Actual division directories: top-level dirs that contain at least one
+# git-TRACKED file, minus the excludes and anything dot-prefixed. Using
+# `git ls-files` (not a filesystem glob) keeps this in lockstep with what CI's
+# clean checkout sees, so a local gitignored scratch dir (e.g. notes/) can't
+# produce a false failure.
 actual_dirs() {
-  local d base
-  for d in */; do
-    base="${d%/}"
+  local base
+  git ls-files | awk -F/ 'NF>1{print $1}' | sort -u | while IFS= read -r base; do
     [[ "$base" == .* ]] && continue
     case " ${NON_DIVISION_DIRS[*]} " in *" $base "*) continue ;; esac
     echo "$base"
-  done | sort -u
+  done
 }
 
 # Contents of a bash AGENT_DIRS=( ... ) array in the given file, one per line.