Add divisions.json — division presentation metadata (label, icon, color) (#592)

* Add divisions.json — presentation metadata (label, icon, color) per division

Establishes a source of truth for how each division (top-level agent directory)
is presented: a display label, a Lucide icon name, and a brand color. Lets the
Agency Agents app (and any other tooling) render divisions consistently —
including fixing "GIS" (was title-cased to "Gis") and covering `gis` +
`integrations`, which had no metadata before.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Make divisions.json the source of truth + enforce in CI

divisions.json now drives the division set. Add scripts/check-divisions.sh
(CI: check-divisions.yml, runs on every PR with no path filter) which fails
if divisions.json disagrees with the directories on disk, the AGENT_DIRS
arrays in convert.sh / lint-agents.sh, or the lint-agents.yml path filters,
or if any entry lacks label/icon/color.

Fixes pre-existing drift surfaced by the new check: integrations was missing
from convert.sh and lint-agents.sh; integrations and strategy were missing
from lint-agents.sh and the lint workflow (so those agents weren't being
linted at all).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

scripts/check-divisions.sh

@@ -0,0 +1,113 @@
+#!/usr/bin/env bash
+#
+# check-divisions.sh — enforce a single source of truth for the division set.
+#
+# divisions.json (repo root) is canonical. This script fails if any of the
+# following disagree with it:
+#   1. The actual top-level agent directories on disk
+#   2. AGENT_DIRS in scripts/convert.sh
+#   3. AGENT_DIRS in scripts/lint-agents.sh
+#   4. The path filters in .github/workflows/lint-agents.yml
+#   5. Every divisions.json entry has label, icon, and color
+#
+# Add a division: create its directory, add an entry to divisions.json, then
+# this script tells you every other place that must be updated. No deps beyond
+# bash 3.2 + coreutils (no jq) so it runs the same on macOS and CI.
+#
+# Usage: ./scripts/check-divisions.sh
+
+set -euo pipefail
+
+cd "$(dirname "$0")/.."
+
+JSON="divisions.json"
+
+# Top-level directories that are NOT divisions. Everything else at the repo
+# root that is a directory is treated as a division (so a new division dir is
+# caught even if nobody remembered to register it).
+NON_DIVISION_DIRS=(examples scripts)
+
+errors=0
+fail() { echo "ERROR $*"; errors=$((errors + 1)); }
+
+# --- sorted, newline-delimited helpers -------------------------------------
+
+# Canonical set: object-valued keys inside the "divisions" object. Scoping to
+# lines after the `"divisions": {` opener excludes both the wrapper key itself
+# and the string-valued "_note" key.
+canonical() {
+  awk '/"divisions"[[:space:]]*:[[:space:]]*\{/{f=1; next} f' "$JSON" \
+    | grep -oE '"[a-z0-9-]+"[[:space:]]*:[[:space:]]*\{' \
+    | sed -E 's/"([a-z0-9-]+)".*/\1/' | sort -u
+}
+
+# Actual division directories on disk (top-level dirs minus the excludes and
+# anything dot-prefixed).
+actual_dirs() {
+  local d base
+  for d in */; do
+    base="${d%/}"
+    [[ "$base" == .* ]] && continue
+    case " ${NON_DIVISION_DIRS[*]} " in *" $base "*) continue ;; esac
+    echo "$base"
+  done | sort -u
+}
+
+# Contents of a bash AGENT_DIRS=( ... ) array in the given file, one per line.
+agent_dirs_array() {
+  awk '/AGENT_DIRS=\(/{f=1; next} f && /^\)/{exit} f{print}' "$1" \
+    | tr ' \t' '\n\n' | grep -E '^[a-z0-9-]+$' | sort -u
+}
+
+# Compare canonical vs a candidate set; report both directions.
+compare() {
+  local label="$1" candidate="$2" canon
+  canon="$(canonical)"
+  local missing extra
+  missing="$(comm -23 <(echo "$canon") <(echo "$candidate"))"
+  extra="$(comm -13 <(echo "$canon") <(echo "$candidate"))"
+  if [[ -n "$missing" ]]; then
+    fail "$label is missing division(s) present in $JSON: $(echo "$missing" | tr '\n' ' ')"
+  fi
+  if [[ -n "$extra" ]]; then
+    fail "$label has division(s) not in $JSON: $(echo "$extra" | tr '\n' ' ')"
+  fi
+}
+
+# --- checks ----------------------------------------------------------------
+
+[[ -f "$JSON" ]] || { echo "ERROR $JSON not found at repo root"; exit 1; }
+
+compare "the agent directories on disk" "$(actual_dirs)"
+compare "scripts/convert.sh AGENT_DIRS" "$(agent_dirs_array scripts/convert.sh)"
+compare "scripts/lint-agents.sh AGENT_DIRS" "$(agent_dirs_array scripts/lint-agents.sh)"
+
+# Workflow path filters: every canonical division must appear as `<div>/` in
+# the lint workflow, or new divisions silently skip CI.
+WF=".github/workflows/lint-agents.yml"
+if [[ -f "$WF" ]]; then
+  while IFS= read -r div; do
+    grep -qE "\b${div}/" "$WF" || fail "$WF has no path filter for division '$div'"
+  done < <(canonical)
+else
+  fail "$WF not found"
+fi
+
+# Every entry must have label, icon, and color.
+while IFS= read -r div; do
+  block="$(awk -v d="\"$div\"" '$0 ~ d"[[:space:]]*:[[:space:]]*\\{" {print; found=1; next} found && /\}/ {print; exit} found {print}' "$JSON")"
+  for field in label icon color; do
+    echo "$block" | grep -qE "\"$field\"[[:space:]]*:" \
+      || fail "division '$div' in $JSON is missing \"$field\""
+  done
+done < <(canonical)
+
+# --- result ----------------------------------------------------------------
+
+count="$(canonical | wc -l | tr -d ' ')"
+if [[ $errors -gt 0 ]]; then
+  echo ""
+  echo "FAILED: $errors divisions consistency error(s). $JSON is the source of truth."
+  exit 1
+fi
+echo "PASSED: $count divisions consistent across $JSON, directories, scripts, and CI."

scripts/convert.sh

@@ -67,7 +67,7 @@ TODAY="$(date +%Y-%m-%d)"
 . "$SCRIPT_DIR/lib.sh"
 
 AGENT_DIRS=(
-  academic design engineering finance game-development gis marketing paid-media product project-management
+  academic design engineering finance game-development gis integrations marketing paid-media product project-management
   sales security spatial-computing specialized strategy support testing
 )
 

scripts/lint-agents.sh

@@ -18,6 +18,7 @@ AGENT_DIRS=(
   finance
   game-development
   gis
+  integrations
   marketing
   paid-media
   product
@@ -26,6 +27,7 @@ AGENT_DIRS=(
   security
   spatial-computing
   specialized
+  strategy
   support
   testing
 )