creator/cc-1c-skills
1
0
Fork 0
mirror of https://github.com/Nikolay-Shirokov/cc-1c-skills.git synced 2026-07-17 16:25:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(web-test): detect ambiguous type matches in selectValue

Browse Source 
When multiple types match the search term in the type selection dialog,
throw a descriptive error listing all matches instead of silently
picking the first one. This prevents the model from getting a misleading
"not found" error when the wrong type was selected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Nick Shirokov
2026-03-04 20:08:35 +03:00
parent c958f3f818
commit 2e0dcb773b
1 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.claude/skills/web-test/scripts/browser.mjs
+19 -8
View File
@@ -955,31 +955,42 @@ async function pickFromTypeDialog(formNum, typeName) {
await page.click(`#form${findFormNum}_Find`, { force: true }); await page.click(`#form${findFormNum}_Find`, { force: true });
await page.waitForTimeout(3000); await page.waitForTimeout(3000);
// 6. Verify grid WHILE "Найти" is still open (Cancel resets the search) // 6. Read ALL visible grid rows and check how many match the search text.
// After Ctrl+F the grid scrolls to the found row — nearby matching rows are visible too.
// The "Найти" dialog may auto-close after search, so don't rely on clicking "Найти" again.
const gridCheck = await page.evaluate(`(() => { const gridCheck = await page.evaluate(`(() => {
const grid = document.getElementById('form${formNum}_ValueList'); const grid = document.getElementById('form${formNum}_ValueList');
if (!grid) return { visible: [] }; if (!grid) return { visible: [], selected: null };
const body = grid.querySelector('.gridBody'); const body = grid.querySelector('.gridBody');
if (!body) return { visible: [] }; if (!body) return { visible: [], selected: null };
const lines = body.querySelectorAll('.gridLine'); const lines = body.querySelectorAll('.gridLine');
const visible = []; const visible = [];
let selected = null;
for (const line of lines) { for (const line of lines) {
const text = (line.innerText || '').trim().replace(/\\u00a0/g, ' '); const text = (line.innerText || '').trim().replace(/\\u00a0/g, ' ');
if (text) visible.push(text); if (!text) continue;
visible.push(text);
if (line.classList.contains('select') || line.classList.contains('selRow')) selected = text;
} }
return { visible }; return { visible, selected };
})()`); })()`);
const typeNorm = normYo(typeName.toLowerCase()); const typeNorm = normYo(typeName.toLowerCase());
const matchInGrid = gridCheck.visible?.some(t => normYo(t.toLowerCase()).includes(typeNorm)); const matching = (gridCheck.visible || []).filter(t => normYo(t.toLowerCase()).includes(typeNorm));
if (!matchInGrid) {
// Type not found — close dialogs via Escape (multiple times for safety) if (matching.length === 0) {
for (let i = 0; i < 3; i++) { await page.keyboard.press('Escape'); await page.waitForTimeout(300); } for (let i = 0; i < 3; i++) { await page.keyboard.press('Escape'); await page.waitForTimeout(300); }
await waitForStable(); await waitForStable();
throw new Error(`selectValue: type "${typeName}" not found in type selection dialog` + throw new Error(`selectValue: type "${typeName}" not found in type selection dialog` +
`. Visible: ${(gridCheck.visible || []).join(', ')}`); `. Visible: ${(gridCheck.visible || []).join(', ')}`);
} }
if (matching.length > 1) {
for (let i = 0; i < 3; i++) { await page.keyboard.press('Escape'); await page.waitForTimeout(300); }
await waitForStable();
throw new Error(`selectValue: multiple types match "${typeName}": ${matching.map(m => '"' + m + '"').join(', ')}. Specify a more precise type name`);
}
// 7. Click OK on type dialog via page.click({force:true}) — bypasses "Найти" modal // 7. Click OK on type dialog via page.click({force:true}) — bypasses "Найти" modal
await page.click(`#form${formNum}_OK`, { force: true }); await page.click(`#form${formNum}_OK`, { force: true });
await page.waitForTimeout(ACTION_WAIT); await page.waitForTimeout(ACTION_WAIT);