Restructure, per the ask that code review be the parent and the other two dimensions its sub-cases: - SKILL.md gains a "one engine, three anchors" section. Correctness is the core and stays inline; performance and security move to their own reference files, loaded only when selected. - references/performance-review.md (new) — a universal, stack-agnostic core (repeated work, growth relationships, retention, copying, contention, amplification) plus the three-part bar for a performance finding. Defers the database/web checklist to /performance-audit-static instead of restating it. - references/security-review.md (new) — trust boundaries and sinks for code with no web surface, and the one rule that INVERTS relative to correctness: attacker-equals-victim refutes a security finding but never a correctness one. Defers the full procedure to /security-audit-static. - Both audit commands now say they are the specialisation behind their sub-case, so the narrow entry points still lead back to the skill. ship-check gains two stages it was missing: - Step 3, correctness review — the pass neither audit performs: logic and state defects that compile clean and pass the suite. - Step 6, independent unsteered review — a fresh session of a second model (Codex or equivalent), given no checklist and no prior findings, with the subject computed from a diff rather than described. Every finding is hand-verified against the code before it enters the packet, since an unsteered reviewer carries no refutation discipline of its own. The packet reports whether it ran clean or did not run at all - those are different signals. Also carries the working-tree edits already in progress: model-and-orchestration guidance on both audits, the OWASP A02/A06/A09 backstop, CSP in the output-encoding bullet, the prompt-injection/agent-abuse bullet, and the Audit Provenance section (now also naming the second model). No version bump - not tested against the benchmark yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G42vsxSKL7je39AsHZ5aJm
9.7 KiB
description, argument-hint
| description | argument-hint |
|---|---|
| Static security audit of AI-built code — map trust boundaries, cross-reference documented intent, self-refute every finding, and report only evidence-backed risks | <repo path or area; defaults to the whole repository> |
/security-audit-static -- Audit the Code You Already Have
A focused, self-contained security audit for AI-built code. It keeps a small, durable engine — map the boundaries, check intent against implementation, refute before reporting — and refuses to emit anything it can't back with cited evidence.
This is a review, not a guarantee: it produces code-review findings, not confirmed exploits.
Method adapted from the public, Apache-2.0
security-guidanceplugin in Anthropic'sclaude-plugins-officialrepository. Not affiliated with or endorsed by Anthropic.
Invocation
/security-audit-static
/security-audit-static supabase/functions
Scope
Audit $ARGUMENTS. If empty, audit the whole repository, prioritizing request handlers, auth, data access, background jobs, and anything that renders, fetches, executes, logs, or stores user-controlled data. For non-trivial scopes, fan out with parallel subagents — one per function/module cluster, each running the mapping and inspection (steps 1–3); then merge candidates and run the self-refute (step 4) yourself over the full set.
Model and orchestration
- Run every subagent on the strongest model available — Fable or Mythos when you have access, otherwise Opus 4.8. Match the effort level of the current session when the surface exposes it. This is recall-first work: a missed cross-file flow is the costly failure, so don't let a cluster silently drop to a cheaper model or a lower effort.
- Expect reroutes, and report them. A security audit is exactly the content Fable's safety classifiers screen for, so some subagents will be automatically rerouted to Opus 4.8. That is fine for this work — but say so. Note in the report which clusters ran on the fallback model, so the reader knows the audit's model mix instead of assuming one model saw everything.
- Flat fan-out, not a workflow. One level of parallel subagents (parent → cluster auditors → merge) is the target. Nest a second level only when a single cluster is too big for one agent's context. A deep org chart or a self-generating workflow adds coordination cost without improving recall here.
The audit (small engine, strong constraint)
1. Map entry points to trust boundaries and sinks
Optimize for recall first — read every file in scope in full, then grep for handler, route, RPC, and shared-helper names to find callers and downstream sinks. Reading the file that contains the bug is what prevents missing it.
Entry points: HTTP/RPC handlers, edge/serverless functions, webhooks, queue consumers, upload handlers, auth callbacks, cron-triggered endpoints. Sinks: raw SQL / query filters, shell/exec, eval / new Function / dynamic imports, HTML render and templates, outbound fetches, filesystem paths, IAM/role writes, logs and analytics, deserializers (incl. YAML/XML and archive extraction), response headers / cache-control, and LLM prompts and tool calls (prompt injection). For every value reaching a sink, decide whether an attacker can influence it and trace it back to its source.
2. Inspect the four high-value paths
Authorization, data access, session/identity, and input→output encoding. Compare sibling handlers — if one enforces a check another omits, the omission is a finding. Follow cross-file flows; input in module A reaching a dangerous operation in module B is where the real bugs hide.
3. Cross-reference intended vs. implemented
Apply the intended-vs-implemented skill against /documentation/*.md. A rule documented but not enforced in code is a finding on its own. If the docs are absent, note it and recommend /document-app first — an intent audit needs intent on record.
4. Self-refute every candidate
For each finding, try to disprove it. Default to keep unless you find cited evidence (file + line) for one of: a real sanitizer/encoder/validator/authorization check stops the exploit at the sink; the sink is non-dangerous (typed, hardcoded, isolated, schema-decoded); a frontend gate is independently re-enforced on the backend; an unvalidated credential is immediately forwarded to an upstream system that validates it; a config/flag gates the path and users can't influence it per request; or the path isn't reachable in production.
Name the attacker and the victim: refute if the only victim is the attacker on their own machine/account/tenant/data and no shared system or privilege boundary is crossed; keep if the impact reaches other users, tenants, shared infrastructure, billing, email reputation, secrets, or compliance-sensitive data. Never apply attacker-equals-victim refutation to SSRF/outbound-network sinks, shared billing or quota sinks, data-exposure findings, cross-tenant or cross-principal flows, or server-side execution/rendering — those harm someone other than the attacker by definition. Never refute a finding merely because the code is pre-existing — pre-existing bugs are the point. Do not speculate.
5. Report only what survives — with an OWASP Top 10 backstop
Before writing the report, map every surviving finding to its OWASP Top 10 category, and flag any category with zero findings as an explicit "not covered — double-check" line. This catches the classes this engine underweights: A02 cryptographic failures (plaintext or weakly-hashed credentials, tokens, or PII at rest; predictable tokens; missing encryption on sensitive columns), A06 vulnerable and outdated components (a dependency with a reachable exploit path — not version-drift noise), and A09 logging and monitoring failures (auth failures, access-control denials, and privileged actions that leave no trace for detection). The backstop is a coverage check, not a mandate to invent findings — an honest "no evidence found in A02" is a valid result.
High-miss checklist (technology-shaped, not stack-specific)
Apply these — they're where AI-built apps most often fail:
- Service-role / disabled-RLS boundaries — if the DB client bypasses row-level security, every authorization decision must be in code; flag queries missing the org/owner filter.
- Auth-provider drift — claims from an external identity provider (e.g. Clerk) trusted without verifying how they map to data scope.
- Gate/action field mismatch — permission checked on one ID, action performed on an independent ID never proven to belong to it.
- Forgeable request signals — endpoints gated by
?source=cron,?bot=1, guessable headers, or unsigned webhook-like payloads instead of real auth. Raise severity when the endpoint mutates data, sends email, or triggers paid usage. - Output encoding vs. input validation, and CSP — user data interpolated into HTML,
<title>, attributes, JSON-LD, SQL, or Markdown must be encoded for that sink; input validation doesn't count. Check the Content-Security-Policy itself: weak or missing directives,unsafe-inline, wildcard sources, inline event handlers — recommend a stricter policy that still supports app features. (XSS, CSP.) - Prompt injection and agent abuse (AI apps) — treat the model as both a sink and a source. Untrusted content (fetched pages, uploaded files, DB rows, tool output) reaching an LLM prompt; attacker text driving a privileged tool call or agent action (confused deputy); system-prompt or secret exfiltration; and unvalidated LLM output flowing into a downstream sink (SQL, shell, HTML, a follow-on tool call).
- SSRF / renderer abuse — attacker-influenced URLs, HTML, SVG, or Markdown reaching an outbound fetch or a renderer (headless browser, PDF/OG-image generator).
- Parser / validator differentials — the validator accepts a value the consumer interprets differently: unanchored regex,
startsWith/substring allowlists, URL-parser disagreement, encoding/case/slash/path-normalization mismatch, or validation on one representation and execution on another. - Fail-open paths — error,
catch, timeout, cancellation, cache-miss, stale-cache, feature-flag, or boundary-value branches that default to allow. AI code loves a permissive fallback. - Secrets / PII to observability — credentials, tokens, emails, or sensitive data reaching logs, traces, analytics, or error bodies; check error branches especially.
- Public-data-only violations — SPA/SEO bot routes or "public" endpoints over-fetching private fields.
Output
Group surviving findings by file, sorted by severity, in the standard format:
Security Audit: [scope]
<file>:
N. [SEVERITY] [Category] <location>
Risk Level: Critical | High | Medium | Low
Attack Scenario: <attacker -> sink -> impact, step by step>
Impact: <what data or functionality is compromised>
Solution: <concrete code change>
End with: the root-cause theme across findings; what is well-built — say it explicitly; and what you could not verify and the user should double-check. Optionally write the report to /reports/security_audit_{timestamp}.md.
Notes
- Don't report generic hardening with no concrete impact, outdated deps without a reachable path, or test/mock code unless it ships. Logic and authorization bugs with no classic sink still count.
- This command covers security only. For over-fetching, indexes, and caching, use
/performance-audit-static. - This is the specialised procedure behind the code-review skill's security sub-case. For logic and state defects, or for a review across several dimensions at once, use
/pm-ai-shipping:code-review. - For an end-to-end pass that documents first and produces a shipping packet, use
/ship-check.